Repository navigation
Per-node kernel arguments for the installed OS - #392
Merged
Merged
Conversation
Member
|
ok, take care of the attribute.py conflict now |
Kernel arguments for the installed OS could only be set per profile, with installedargs in profile.yaml. deployment.installedargs sets them per node or group, appended after the ones of the profile. The deploycfg served to the node carries the value as installedargs, and the installers add it wherever they add the profile installedargs: the kickstart bootloader line on EL and RHVH, the AutoYaST and Agama bootloader settings on SUSE, and GRUB_CMDLINE_LINUX on Debian and Ubuntu. Diskless images installed to disk add it to GRUB_CMDLINE_LINUX, and on EL9 and EL10 also to /etc/kernel/cmdline and the boot loader entries. deploycfg is no longer wrapped at 80 columns, since the scripts read each value from its single line.
The installedargs of profile.yaml only reached systems installed by an OS installer. A diskless image written to disk with installtodisk got none of them, and keeps from the network boot only console=, net.ifnames=, biosdevname= and quiet, so arguments meant for the installed system had to be baked into the image. image2disk.py now fetches the profile.yaml of the deployment and adds its installedargs before deployment.installedargs, in the same places. An argument the image already has, as when it was captured from a node installed this way, is kept once, in its last position, so the node arguments still come last, and a profile.yaml that cannot be read only skips the profile arguments instead of failing the install.
Obihoernchen
force-pushed
the
feat/node-installedargs
branch
from
November 18, 2026 22:44
f6f5dae to
d4bea73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
deployment.installedargs, appended after the profileinstalledargsin the bootloader configuration of the installed system. It reaches the node through deploycfg.Diskless images installed to disk (
installtodisk) now also apply the profileinstalledargs, which were ignored on that path before. An argument the image already has is kept once, so captured images do not accumulate copies.installedargsdeployment.installedargscrashkernel=1G... crashkernel=1Gcrashkernel=1Gnohz_full=4-63... crashkernel=1G nohz_full=4-63panic=5panic=30... panic=5 panic=30(node wins)bootloader --append<append>/ AgamaextraKernelParamsGRUB_CMDLINE_LINUXGRUB_CMDLINE_LINUXGRUB_CMDLINE_LINUX,/etc/kernel/cmdline, boot loader entriesCharacters GRUB treats specially (
&,;,|,<,>,$, quotes) are not supported. For network boot arguments see #391.Tested on EL9, EL10, Ubuntu 24.04, Ubuntu 26.04 and Leap 16.